• aodhsishaj@lemmy.world
    link
    fedilink
    English
    arrow-up
    23
    ·
    4 months ago

    How could one Dev commit to prod without other Devs reviewing the MR? IF you’re not protecting your prod branch that’s a cultural issue. I don’t know where you’ve worked in the past, or where you’re working now, but once it’s N+1 engineers in a code base there needs to be code reviews.

      • aodhsishaj@lemmy.world
        link
        fedilink
        English
        arrow-up
        10
        ·
        4 months ago

        I would hate to work where you developed the idea a protected main/prod branch is something novel.

      • erwan@lemmy.ml
        link
        fedilink
        English
        arrow-up
        10
        ·
        4 months ago

        I hate to break it to you, but companies with actual safe rails to deploying to production do exist.

        And when things go wrong, it’s never the responsibility on a single dev. It’s also the dev who reviewed the PR. It’s also the dev who buddy approved the deploy. It’s the whole department that didn’t have enough coverage in CI.