Working on /kbin
https://fedidb.org/software/kbin
At the end of the day, I wanted to thank you for that reminder. Sometimes I really need it. For now, these two PRs will have to suffice. I’m sure I modeled them after Postmill. I can promise I’ll get back to this and do it right.
Thank you for that, Adam.
https://codeberg.org/Kbin/kbin-core/pulls/1005
https://codeberg.org/Kbin/kbin-core/pulls/1006
It took me from 4 to 6 minutes, I can’t determine exactly. I think this is about more than just copying and committing a file - one needs to label specific files or sections of the code. I’m not sure how exactly this should look, so I’m waiting for a consultation.
Most of the indicated code is no longer part of kbin (unlike Pixelfed’s code, to be fair). You can see the similarities in the links provided above. However, I need to thoroughly analyze everything once again to make sure nothing slipped past me and there isn’t more of it. There might be a tool that could facilitate this. In any case, it’s not my intention to hide the original source, even if major changes have been made. I’d gladly leave information about what the code was based on. I have no problem with that, the only enemy is time.
I think several factors contributed to this. First, I prepared the licensing tag, but when the time came to merge the branch - that code simply no longer existed. As you can see, the remaining files are what I call inspiration - it’s not copied code but more of an overall concept, quite common in these types of applications (however, I’m not saying that there shouldn’t be a tag). Another factor is that sometimes you have to choose what to focus on first - eliminate and remove thousands of spambots, fix activitypub communication after updates from other software so as not to crash your server and others, secure the instance from sensitive content, deal with all the formalities related to the legal situation, working on moteration tools, handle pull requests from people who dedicate their private time to it and many more. Additional, I still need to make sure I can pay my own bills, and there’s personal life.
And yes, two months is a long time, but for me, it was just a flash this time. A swift reality check occurred because the first release was supposed to come out over a month ago. I’m doing this the best I can, and without the help of contributors, none of this would have been possible. Due to the situation, I have to prioritize certain tasks. This is still marked as high priority, but it’s waiting its turn. Nevertheless, I have the opportunity, I decided to seek external help to do it the right way before releasing the first version. I realized that it only seems like a simple task on the surface. I want close the matter once and for all. All of this also pertains to the licensing tags of Pixelfed, btw.
As I said, the markdown implementation that received the main thing has been rewritten by contributors. I need to consult on how it should look in such a case. Now the indicated similarities are between these files (these files will also be changed soon, before release):
https://codeberg.org/Kbin/kbin-core/src/branch/develop/src/Repository/Criteria.php
https://gitlab.com/postmill/Postmill/-/blob/1e98b99bc4a20b396f2fa4089bdb1a308b7e18fd/src/SubmissionFinder/Criteria.php
https://gitlab.com/postmill/Postmill/-/blob/a9704316c1c78f15ca12c2dc5ad477f4ac9f530e/src/Entity/Submission.php#L21-57
Since then, over 230 pull requests have been accepted. I had a branch where I was working on this, but a lot of code has changed in the meantime - among other things, ex the markdown implementation has been rewritten and, in fact, some of it is now outdated. Many files will still change and be rewritten before the release.
Before the first release, it will be done properly, and I will probably seek help and consultation from the right people https://codeberg.org/Kbin/kbin-core/pulls/937. Currently, in the project’s readme, I’ve clearly indicated that kbin is inspired by Postmill. Unfortunately, recently I’ve been overwhelmed by some personal matters, which caused me to neglect certain things. Now I’m doing everything to bring kbin to the appropriate state.
@AskThinkingTim A few days ago, kbin wasn’t on that list at all :) It’s a huge honor for me, and I’m glad people are enjoying being here. Currently, my main goal is to prepare the infrastructure and sort out the basics. The real fun will start when migratories between platforms are established. This is the fediverse, and a lot can change here ;)
@maegul kbin supports those groups btw ;)
https://kbin.social/magazines?query=a.gup.pe+&fields=names&federation=all&adult=hide
https://kbin.social/magazines?query=chirp.social&fields=names&federation=all&adult=hide
@feditips @FediFollows @masimatutu @sabreW4K3